rs_trigger support #248
Open
rs_trigger support #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
povik
requested changes
Nov 13, 2025
| } | ||
|
|
||
| if (aloads.size() > 1) { | ||
| if (aloads.size() > 2) { |
Owner
There was a problem hiding this comment.
Please update the diagnostic text for "more than two unsupported"
| for (auto driven_chunk2 : dffsr_q.chunks()) { | ||
| for (auto [named_chunk, name] : generate_subfield_names(driven_chunk2, type)) { | ||
| auto set = netlist.Mux(RTLIL::SigSpec(0, named_chunk.bitwidth()), | ||
| RTLIL::SigSpec(-1, named_chunk.bitwidth()), aloads[1].trigger); |
Owner
There was a problem hiding this comment.
I think this assumes the clear always comes before the reset. Consider e.g.
always @(negedge CLK or posedge A or posedge B) begin
if (A)
Q <= 8'b1111_0000;
else if (B)
Q <= 8'b0000_1111;
else
Q <= D1;
end
Owner
There was a problem hiding this comment.
It's not. I think for the above example the set and clear signals will be inferred the wrong way for some of the bits. Also we need to arrange if both A and B are high, then A takes precedence. I'm not sure how Yosys deals with it
povik
reviewed
Nov 13, 2025
| @@ -0,0 +1,88 @@ | |||
| read_slang <<EOF | |||
Owner
There was a problem hiding this comment.
Test needs to be added to CMakeLists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169
yosys-slang produces error message "multiple asynchronous loads unsupported" for following construction(always block with clock plus two asynchronous signals):
but native yosys's read_verilog does not, and generates
$dffsrcell.The fix allows such construction and issues
$dffsrcell call producing rtlil